Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sylius 1.10 support #264

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Conversation

oallain
Copy link
Member

@oallain oallain commented Jul 3, 2021

Q A
Bug fix? no
New feature? yes
BC breaks? no
Fixed tickets #263

Add Sylius 1.10 support.

@oallain oallain marked this pull request as ready for review July 3, 2021 13:41
@oallain oallain requested a review from lsmith77 as a code owner July 3, 2021 13:41
@@ -5,7 +5,7 @@
"license": "MIT",
"require": {
"php": "^7.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to allow php8 ? 😇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not without addressing #260 at a minimum.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if you feel like PR will be welcome.

@andriusvo
Copy link

@oallain can it be merged and new tag released?

@oallain oallain merged commit b6da43e into FriendsOfSylius:master Jul 9, 2021
@oallain oallain deleted the sylius-1-10 branch July 9, 2021 17:06
@oallain
Copy link
Member Author

oallain commented Jul 9, 2021

@andriusvo it's done #263 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants